fix: update constant name for min required version of WPGraphQL #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jasonbahl
commented
Nov 22, 2022
jasonbahl
commented
- update constant name to check the min WPGraphQL version. The constant name was the same as the constant defined in WPGraphQL for ACF extension, so the version check was sometimes using that constant, depending on the order of activation
…onstant name conflicted with the WPGraphQL for ACF extension
Contributor
|
Hi @jasonbahl, I was just testing the latest version of the plugin on a local install and started getting a PHP Fatal error. It looks like one of the constants wasn't renamed I just thought I'd leave this here 'cause I'm not sure if the plugin is open for contribution yet. Thanks! |
Collaborator
Author
|
@colis ah shoot. Good catch. Please feel free to contribute a PR 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.