fix: post meta array on preview #3422
Merged
+114
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew meta When $single is true, WordPress core's get_post_metadata filter returns the first value from an array. This fix ensures proper array wrapping to maintain expected behavior in GraphQL preview requests. Ref: https://github.com/WordPress/wordpress-develop/blob/2fe26ceb7a1f3fb57ec8726fc5f425d00a12ace9/src/wp-includes/meta.php#L666
Collaborator
|
@PatelUtkarsh thanks for this PR! Would you have any interest in contributing a test for this? An ideal test would be one that makes a preview query that includes meta and fails without this fix in place but passes with this fix in place. |
Contributor
Author
|
@jasonbahl I've added tests in latest commit. |
jasonbahl
approved these changes
Oct 2, 2025
Collaborator
|
Thanks @PatelUtkarsh! 🙌🏻 |
Contributor
Author
|
Hello @jasonbahl, I couldn't figure out how to run the specific file / method in the setup, I tried setting up SUITS env. Do you have any advice on that? |
Collaborator
|
super close! Instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When meta is stored as serialize array in post meta table, during preview instead of returning array it returns first value from array.
When
$singleis true, WordPress core'sget_post_metadatafilter returns the first value from an array. This fix ensures proper array wrapping to return array back when stored value is array.Ref: https://github.com/WordPress/wordpress-develop/blob/2fe26ceb7a1f3fb57ec8726fc5f425d00a12ace9/src/wp-includes/meta.php#L666
Does this close any currently open issues?
Any other comments?