Skip to content

Conversation

@jasonbahl
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This updates the plugin to be compatible with Git Updater by setting Release Asset: true header and updating the release workflow to upload an asset named $repo-$tag.zip following the docs here: https://git-updater.com/knowledge-base/required-headers/

Does this close any currently open issues?

closes #3418

…umber

- update plugin header to be compatible with Github Plugin Updater using release asset
@afragen
Copy link

afragen commented Sep 25, 2025

Additions to the GitHub Action are not necessary.

@jasonbahl
Copy link
Collaborator Author

@afragen ok, my understanding from the docs for the Release Asset header (https://git-updater.com/knowledge-base/required-headers/) made it seem like if there were more than 1 release asset per release it needed this naming convention, and since we upload multiple assets I thought this was necessary?

CleanShot 2025-09-26 at 09 52 31

@coveralls
Copy link

coveralls commented Sep 26, 2025

Coverage Status

coverage: 84.574%. remained the same
when pulling 710d7be on jasonbahl:fix/3418-github-updater
into b3ce4f0 on wp-graphql:develop.

@afragen
Copy link

afragen commented Sep 26, 2025

I'll check this more closely and let you know where the current release asset points to.

@afragen
Copy link

afragen commented Sep 26, 2025

I have to thank you @jasonbahl as I haven't really encountered anyone who has more than one release asset per release. I was previously picking up the first release asset, which in your case would be schema.graphql.

I've created a fix in my develop branch that will pick the release asset whose name starts with the repo's slug. Therefore it is not necessary to include the version number.

I should merge this and release by early next week. I will also update my KB doc. Thanks.

@jasonbahl jasonbahl merged commit 84c314d into wp-graphql:develop Oct 1, 2025
34 checks passed
pull bot pushed a commit to Zezo-Ai/wp-graphql that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version on WP Plugin Repository Contains a Git-Updator Header which breaks it if Git-Updator updates it.

3 participants