-
Notifications
You must be signed in to change notification settings - Fork 466
fix: git updater compatibility #3420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: git updater compatibility #3420
Conversation
…umber - update plugin header to be compatible with Github Plugin Updater using release asset
|
Additions to the GitHub Action are not necessary. |
|
@afragen ok, my understanding from the docs for the Release Asset header (https://git-updater.com/knowledge-base/required-headers/) made it seem like if there were more than 1 release asset per release it needed this naming convention, and since we upload multiple assets I thought this was necessary?
|
|
I'll check this more closely and let you know where the current release asset points to. |
|
I have to thank you @jasonbahl as I haven't really encountered anyone who has more than one release asset per release. I was previously picking up the first release asset, which in your case would be I've created a fix in my I should merge this and release by early next week. I will also update my KB doc. Thanks. |

What does this implement/fix? Explain your changes.
This updates the plugin to be compatible with Git Updater by setting
Release Asset: trueheader and updating the release workflow to upload an asset named$repo-$tag.zipfollowing the docs here: https://git-updater.com/knowledge-base/required-headers/Does this close any currently open issues?
closes #3418