refactor: prepare deprecations for v3 removal #3400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the WPGraphQL codebase for v3.0 by reorganizing deprecated functionality and improving deprecation warnings. The primary goal is to consolidate deprecated code and provide clearer messaging about upcoming removals to help both human developers and AI/LLM agents understand what is actually relevant in the codebase.
- Creates a new
WPGraphQL\Deprecatedclass to handle deprecated functionality registration - Moves deprecated classes to a new
/deprecateddirectory (added to Composer classmap) - Updates existing deprecation warnings to explicitly mention removal in the next major version
Reviewed Changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WPGraphQL.php | Adds deprecated functionality initialization and removes inline deprecated filter |
| src/Deprecated.php | New class consolidating all deprecated type and field registrations |
| deprecated/*.php | Relocated deprecated classes with updated warning messages |
| src/Type/ObjectType/RootQuery.php | Removes deprecated postBy field registration (moved to Deprecated class) |
| src/Type/ObjectType/MenuItem.php | Removes deprecated connectedObject field (moved to Deprecated class) |
| src/Registry/TypeRegistry.php | Removes deprecated union type registrations (moved to Deprecated class) |
| src/Model/Post.php | Updates sourceUrlsBySize deprecation message |
| src/Router.php | Moves deprecated is_graphql_request method to end of class with updated warning |
| composer.json | Adds deprecated/ directory to classmap |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
justlevine
added
status: in review
Collaborator
|
Good work! Will go through more thoroughly tomorrow 🙌 |
jasonbahl
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR prepares the groundwork for removing deprecated parts of the codebase in WPGraphQL v3.0,
/deprecateddirectory (added by Composer ClassMap)WPGraphQL/Deprecated.phpclass.While code quality and cleanliness have always been nice - and a lot of these removals were already slated for 3.0, the impact of having this old code on agents and LLMs is becoming a major hinderance. So isolating things now and making it clearer that these things are not actually relevant to the codebase will be immediately helpful for both humans and 🤖
Does this close any currently open issues?
Any other comments?