-
Notifications
You must be signed in to change notification settings - Fork 466
chore: update Composer dev-deps and PHPCs ruleset #3379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+435
−418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates Composer development dependencies and adjusts the PHPCS ruleset to suppress deprecation warnings ahead of PHPCS 4.0.
- Replace single-line VIP Go standard import with block that excludes a deprecated JS rule until PHPCS 4
- Add exclusion for call-time pass-by-reference warning under WordPress rules with a TODO for PHPCS v4
|
Code Climate has analyzed commit 12d0564 and detected 0 issues on this pull request. View more on Code Climate. |
jasonbahl
approved these changes
Jun 2, 2025
jasonbahl
approved these changes
Jun 2, 2025
justlevine
pushed a commit
to justlevine/wp-graphql
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs: reviewer response
This needs the attention of a codeowner or maintainer
scope: code quality
Refactoring, linting, and enforcing coding standards
status: in review
Awaiting review before merging or closing
type: chore
Maintenance tasks, refactoring, and other non-functional changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR updates all the Composer dev-deps to their latest (semver-compatible) versions.
The
phpcs.xml.distruleset has been updated to accommodate the new deprecation messages regarding the incoming PHPCS v4.0Does this close any currently open issues?
No
Any other comments?