Skip to content

Conversation

@justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR updates all the Composer dev-deps to their latest (semver-compatible) versions.

The phpcs.xml.dist ruleset has been updated to accommodate the new deprecation messages regarding the incoming PHPCS v4.0

Does this close any currently open issues?

No

Any other comments?

@justlevine justlevine requested review from Copilot and jasonbahl May 19, 2025 07:54
@justlevine justlevine added status: in review Awaiting review before merging or closing needs: reviewer response This needs the attention of a codeowner or maintainer scope: code quality Refactoring, linting, and enforcing coding standards type: chore Maintenance tasks, refactoring, and other non-functional changes labels May 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Composer development dependencies and adjusts the PHPCS ruleset to suppress deprecation warnings ahead of PHPCS 4.0.

  • Replace single-line VIP Go standard import with block that excludes a deprecated JS rule until PHPCS 4
  • Add exclusion for call-time pass-by-reference warning under WordPress rules with a TODO for PHPCS v4

@coveralls
Copy link

coveralls commented May 19, 2025

Coverage Status

coverage: 84.234%. remained the same
when pulling 12d0564 on justlevine:chore/phpcs-deps
into 161565b on wp-graphql:develop.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 12d0564 and detected 0 issues on this pull request.

View more on Code Climate.

@jasonbahl jasonbahl merged commit 11b8ade into wp-graphql:develop Jun 2, 2025
38 checks passed
@justlevine justlevine deleted the chore/phpcs-deps branch June 2, 2025 20:50
justlevine pushed a commit to justlevine/wp-graphql that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: reviewer response This needs the attention of a codeowner or maintainer scope: code quality Refactoring, linting, and enforcing coding standards status: in review Awaiting review before merging or closing type: chore Maintenance tasks, refactoring, and other non-functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants