chore: expose array shape for register_graphql_scalar() $config
#3374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
added
needs: reviewer response
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 8be4e3e and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 23 changed files in this pull request and generated no comments.
Files not reviewed (20)
- access-functions.php: Language not supported
- src/AppContext.php: Language not supported
- src/Data/Connection/AbstractConnectionResolver.php: Language not supported
- src/Data/DataSource.php: Language not supported
- src/Data/Loader/AbstractDataLoader.php: Language not supported
- src/Registry/TypeRegistry.php: Language not supported
- src/Request.php: Language not supported
- src/Router.php: Language not supported
- src/Server/ValidationRules/QueryDepth.php: Language not supported
- src/Server/WPHelper.php: Language not supported
- src/Type/Enum/ContentNodeIdTypeEnum.php: Language not supported
- src/Type/Enum/PluginStatusEnum.php: Language not supported
- src/Type/Enum/PostStatusEnum.php: Language not supported
- src/Type/Enum/TermNodeIdTypeEnum.php: Language not supported
- src/Type/Enum/UserNodeIdTypeEnum.php: Language not supported
- src/Type/WPEnumType.php: Language not supported
- src/Type/WPScalar.php: Language not supported
- src/Utils/InstrumentSchema.php: Language not supported
- src/Utils/QueryAnalyzer.php: Language not supported
- src/Utils/QueryLog.php: Language not supported
jasonbahl
previously approved these changes
May 5, 2025
justlevine
dismissed
jasonbahl’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR improves the type hinting inside
WPScalarto use explicit array shapes instead of mixed whenever possible, all the way through to the register_graphql_scalar()$configarray.Important
This PR is based on #3373 , which should be merged first.
Relevant diff: 8be4e3e
Does this close any currently open issues?
Any other comments?