-
Notifications
You must be signed in to change notification settings - Fork 466
fix: update skipped since tags #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- update release workflow to better handle since tag updates
|
Did we also intentionally skip v2.2 in favor of v2.3? |
|
@justlevine I think the skip must be something going on in my release tooling. It should not have skipped but something in my workflow triggered it to that I need to debug. 😬 Ironically, the automations I put in place to prevent this type of mistake were responsible for this type of mistake 🤦🏻♂️ |
|
@justlevine it looks like maybe I had a 2.2.0 release that didn't properly run and I wasn't paying enough attention to the details because the workflows report they succeeded, but really they didn't. (see: https://github.com/wp-graphql/wp-graphql/actions/runs/13957891456/job/39073292846#step:9:864) 🤔
Got some fixing to do in my automations. 🤦🏻 😬 |
|
@justlevine looks like I had an error in the workflow that was passing the I have it strip the v before deploying to WordPress.org now. Both 2.2.0 and 2.3.0 are on WordPress.org now and I manually published the 2.2.0 release to Github as well. Hopefully this settles the kinks with the workflows. We might find some other issues as we go. Thanks for pointing this out. Gave me a good chance to step back and look at things I was overlooking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
Code Climate has analyzed commit 071da61 and detected 0 issues on this pull request. View more on Code Climate. |

What does this implement/fix? Explain your changes.
This updates missed
@since next-versiontags that weren't properly updated in the previous release.It also updates the release workflow to ensure we properly update since tags during release.