fix: don't initialize Request::$app_context twice in class constructor
#3369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit fed16f8 and detected 0 issues on this pull request. View more on Code Climate. |
justlevine
added
type: bug
justlevine
changed the title
Request::$app_context twice in class constructor
jasonbahl
approved these changes
Apr 28, 2025
jasonbahl
pushed a commit
to justlevine/wp-graphql
that referenced
this pull request
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR fixes a bug in the
Request::__construct()method, where the->app_contextwas previously initialized twice.Now it's only initialized once, while the
$type_registrycontinues to be injected onto the AppContext class at the same point of the lifecycle.Does this close any currently open issues?
Any other comments?