chore: implement array shapes for AdminNotices
#3364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 2764b8d and detected 0 issues on this pull request. View more on Code Climate. |
justlevine
added
status: in review
jasonbahl
approved these changes
Apr 22, 2025
jasonbahl
pushed a commit
to justlevine/wp-graphql
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR implements a reusable PHPStan array shape for the
AdminNoticesclass, removing all unintentional uses formixed. (mixedis still used for the filter, so it can be validated).As a result of this change, PHPStan caught (and this fixes) the incorrect validation of the filtered notice.
There are no breaking changes in this PR.
Any other comments?
LLMs + IDEs + Extenders all really like shaped arrays. This is the first PR of hopefully many getting rid of the
mixedtype however possible.