fix: cleanup Model fields for better source-of-truth and type-safety. #3363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
justlevine
added
status: in review
| return 'revision' === $this->data->post_type; | ||
| }, | ||
| 'isSticky' => function () { | ||
| return is_sticky( $this->data->ID ); |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| return ! empty( $this->data->post_parent ) ? absint( $this->data->post_parent ) : null; | ||
| }, | ||
| 'parentId' => function () { | ||
| return ( ! empty( $this->data->post_type ) && ! empty( $this->parentDatabaseId ) ) ? Relay::toGlobalId( 'post', (string) $this->parentDatabaseId ) : null; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| 'pinged' => function () { | ||
| $punged = get_pung( $this->data->ID ); | ||
|
|
||
| return empty( $punged ) ? null : implode( ',', (array) $punged ); |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| return ! empty( $this->previewRevisionDatabaseId ) ? Relay::toGlobalId( 'post', (string) $this->previewRevisionDatabaseId ) : null; | ||
| // Aliases. | ||
| 'ID' => function () { | ||
| return $this->databaseId; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
|
||
| return false; | ||
| 'post_author' => function () { | ||
| return $this->authorDatabaseId; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
Code Climate has analyzed commit 13b15ca and detected 53 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jasonbahl
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR cleans up the existing WPGraphQL Models in the following ways:
@propertytags and sorts them.fields(cosmetic, to make the diff's easier to read now and in the future)As a result, we're also able to begin enforcing traversable types on new code via PHPStan.
Additional benefits:
Important
This PR is based on #3362 which should be merged first.
Relevant diffs: