fix: use version_compare to simplify incompatible dependent check
#3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
changed the title
version_compare to simplify incompatible dependent checkversion_compare to simplify incompatible dependent check
|
Code Climate has analyzed commit 429fc4e and detected 0 issues on this pull request. View more on Code Climate. |
justlevine
added
status: in review
jasonbahl
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR fixes edge cases in UpdateChecker::is_incompatible_plugin() by replacing the SemVer parser in that function with a basic
version_compare().Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Before:
After:
Any other comments?
Where has this been tested?
Operating System: Ubuntu 24.04 (wsl2 + ddev + php 8.2.26)
WordPress Version: 6.7.1