Skip to content

Conversation

@justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR restores the following PHPCS excluded rules:

  • WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
  • SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing

The remaining singular use of each these have been inlined.

Note

No changes to production code have been made.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

Where has this been tested?

Operating System:

WordPress Version:

@justlevine justlevine requested a review from jasonbahl February 8, 2025 18:37
@justlevine justlevine added status: in review Awaiting review before merging or closing needs: reviewer response This needs the attention of a codeowner or maintainer labels Feb 8, 2025
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit b71c365 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

coverage: 83.194%. remained the same
when pulling b71c365 on justlevine:chore/phpcs-rules
into eb824fd on wp-graphql:develop.

@jasonbahl jasonbahl merged commit a88574a into wp-graphql:develop Feb 10, 2025
36 checks passed
@justlevine justlevine deleted the chore/phpcs-rules branch February 10, 2025 16:49
@jasonbahl jasonbahl mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: reviewer response This needs the attention of a codeowner or maintainer status: in review Awaiting review before merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants