Code Climate has analyzed commit d54d4d0 and detected 0 issues on this pull request.

View more on Code Climate.

coverage: 83.19% (+0.001%) from 83.189%
when pulling d54d4d0 on jasonbahl:fix/3282-plugin-updater-mu-plugin-conflict
into f053fc3 on wp-graphql:develop.

Would love @justlevine to confirm this change doesn't cause any unintended side effects.

I should have time to look this over this weekend, but probably won't have time before. Just glancing at the diff, and it's a smart solve.

I've done some tests and everything seems to work as expected with this change and all of the wpunit tests pass with this change as well.

One thing to note is that much of the admin notice UI work won't show anywhere when WPGraphQL is an mu-plugin due to the fact that:

Plugins in the must-use directory will not appear in the update notifications nor show their update status on the plugins page, so you are responsible for learning about and performing updates on your own.

(source: https://developer.wordpress.org/advanced-administration/plugins/mu-plugins/#caveats)

One thing to note is that much of the admin notice UI work won't show anywhere when WPGraphQL is an mu-plugin due to the fact that:

Plugins in the must-use directory will not appear in the update notifications nor show their update status on the plugins page, so you are responsible for learning about and performing updates on your own.

(source: https://developer.wordpress.org/advanced-administration/plugins/mu-plugins/#caveats)

Curious how woo handles it 🧐