chore: fix bleeding edge/deprecated PHPStan smells [first pass] #3267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
added
status: in review
|
Code Climate has analyzed commit 195a7a6 and detected 0 issues on this pull request. View more on Code Climate. |
jasonbahl
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR:
phpstan/phpstan-deprecation-rulesto the Composer dev-depsBoth of these are part of the PHPStan 2.0 migration path. They're being dealt with here in preparation of the PHP version bump in #3247 which will allow us to upgrade the dependency.
Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
Further bleeding edge fixes will be implemented in future PRs.
Where has this been tested?
Operating System: Ubuntu 24.04 (wsl2 + ddev + php 8.2.26)
WordPress Version: 6.7.1