fix: receiving post for Incorrect uri #3250
Merged
+83
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w a 404, unless there are $extra_query_vars (used to query by slug, id, etc)
justlevine
reviewed
Dec 6, 2024
Collaborator
justlevine
left a comment
justlevine
left a comment
There was a problem hiding this comment.
Instead of extra class props and deviating further from core in methods like ::parse_request(), i'd recommend we implement a register_globals() and handle_404() method.
That's significantly more work though.
3 tasks
|
Code Climate has analyzed commit e901a2f and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where entering a uri for an invalid node might return a node with a different uri.
Does this close any currently open issues?
Closes #3240
With this PR in place, following the same steps to reproduce (as documented in #3240):
Before
Querying for a node by uri might return a node that has a different uri.
After
Now, querying for a node using a uri that would 404 in traditional WP will return a
nullinstead of returning a node that doesn't match the uri input.And querying with the correct uri continues to return the expected node: