Code Climate has analyzed commit 29cfbf4 and detected 0 issues on this pull request.

View more on Code Climate.

coverage: 83.968%. remained the same
when pulling 29cfbf4 on fix/appsero-client
into ff78dd4 on develop.

@justlevine I got some error on updating over composer

wp-graphql-smart-cach
wp-graphql/wp-graphql-smart-cache

Mabye, also need some composer update?

I can't install the new wp-graphql/wp-graphql version.

@Messa1 can you be more specific about what "over composer" means? Are you using WPackagist or something else?

@justlevine

https://github.com/wp-graphql/wp-graphql-smart-cache/blob/5ffd6f59538800342ec2257754b7d9e5d8638c9e/composer.json#L41

https://github.com/wp-graphql/wpgraphql-acf/blob/ef88bd167a7b29489aa56027635f07385b6be443/composer.json#L14

composer.json

  "require": {
    "php": ">=8.0",
    "composer/installers": "^2.2",
    "vlucas/phpdotenv": "^5.5",
    "oscarotero/env": "^2.1",
    "roots/bedrock-autoloader": "^1.0",
    "roots/bedrock-disallow-indexing": "^2.0",
    "roots/wordpress": "6.6.2",
    "roots/wp-config": "1.0.0",
    "roots/wp-password-bcrypt": "1.1.0",
    "wpackagist-theme/twentytwentyfour": "^1.0",
    "wpengine/advanced-custom-fields-pro": "^6.3",
    "wpengine/wp-graphql-content-blocks": "dev-main",
    "wp-graphql/wp-graphql": "^1.29",
    "wp-graphql/wpgraphql-acf": "^2.4",
    "wp-graphql/wp-graphql-smart-cache": "^1.3.3",
    }

Yup as expected, you're installing the source (from wp-graphql/wp-graphql instead of using WPackagist, so Composer is trying to rebuild the dependencies instead of using those shipped in the plugins.

(Iirc smart-cache is on .org too so you might want to use wpackagist-plugin/wp-graphql-smart-cache too)

@justlevine

  Problem 1
    - Root composer.json requires wpackagist-plugin/wp-graphql-smart-cache, it could not be found in any version, there may be a typo in the package name.

@Messa1 it's wpgraphql-smart-cache

see: https://wpackagist.org/search?q=wpgraphql-smart-cache&type=any&search=

At some point WordPress.org stopped allowing plugins that started with wp- so we had to go with wpgraphql without the first - when we released WPGraphQL Smart Cache.