feat: submit an extension criteria and validation #3236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons page works - add /packages/extensions/README.md file explaining how the extensions react app works
- added a `/schemas` directory with schemas for `extensions.json` and `single-extension.json` and a README.md explaining the schemas
…on adding back more one at a time following the new processes.
…s better. Provided documentation for how to filter extensions (modify / override the list of extensions)
- re-built the react app
jasonbahl
changed the title
justlevine
reviewed
Nov 30, 2024
Collaborator
|
@jasonbahl I opened a PR showing an alternative PHP-only approach in #3246 - for your consideration. |
refactor: validate extensions with PHP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR adds the following:
schemas/extensions.jsonto ensure that any changes to the extensions.json file (PRs to the community, etc) in the future are valid.graphql_get_extensions: Filter the list of extensionsgraphql_pre_get_extensions: Prevent the JSON file from being loaded in the first place (i.e. override it completely)