fix: Deprecated null value warning in titleRendered callback#3229
Merged
jasonbahl merged 4 commits intowp-graphql:release/v1.29.1from Nov 13, 2024
Merged
fix: Deprecated null value warning in titleRendered callback#3229jasonbahl merged 4 commits intowp-graphql:release/v1.29.1from
titleRendered callback#3229jasonbahl merged 4 commits intowp-graphql:release/v1.29.1from
Conversation
Collaborator
|
Great catch! We still want the resolver to return |
justlevine
changed the title
titleRendered callback
justlevine
added
type: bug
justlevine
changed the title
titleRendered callbacktitleRendered callback
Contributor
Author
|
Perhaps something like this: 'titleRendered' => function () { }, |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return $this->html_entity_decode( apply_filters( 'the_title', $title, $id ), 'titleRendered', true ); | ||
| $processedTitle = !empty($title) ? $this->html_entity_decode( apply_filters( 'the_title', $title, $id ), 'titleRendered', true ) : ''; | ||
|
|
||
| return $processedTitle === '' ? null : $processedTitle; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
jasonbahl
reviewed
Nov 13, 2024
- formatting
jasonbahl
reviewed
Nov 13, 2024
| return $this->html_entity_decode( apply_filters( 'the_title', $title, $id ), 'titleRendered', true ); | ||
| $processedTitle = ! empty( $title ) ? $this->html_entity_decode( apply_filters( 'the_title', $title, $id ), 'titleRendered', true ) : ''; | ||
|
|
||
| return empty( $processedTitle ) ? null : $processedTitle; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
Code Climate has analyzed commit ebd83de and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a deprecation warning in PHP 8+ caused by passing a null value to the trim() function within the titleRendered method. Previously, if $this->data->post_title was null, it would be passed to apply_filters, potentially resulting in a null value for trim(). This caused a warning in environments using PHP 8+.
Changes Made:
Reason for Change:
Testing Notes: