test: add tests for querying different sizes of media items #3219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tests querying the sourceUrl field and fileSize field on Media Item with various size arguments - unit tests the testGetSourceUrlBySize function
jasonbahl
added
the
scope: tests
- add image file that was not included in the previous commit
|
Code Climate has analyzed commit 5b3e0dd and detected 0 issues on this pull request. View more on Code Climate. |
justlevine
approved these changes
Oct 29, 2024
Collaborator
There was a problem hiding this comment.
From the coveralls and the test contents, this is probably good enough.
Two potential cases to add - your call if they're worth it.
- That our default size is the same one as the explicit one
- That a custom registered size works as expected (e.g. a product_thumb or a size slug woo uses IRL)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This adds tests for the PR #3214
Does this close any currently open issues?
n/a