Skip to content

Conversation

@josephfusco
Copy link
Member

@josephfusco josephfusco commented Sep 3, 2024

What does this implement/fix? Explain your changes.

This fixes a bug where the connectedTerms connection was returning terms of any taxonomy instead of a specific relevant taxonomy.

Does this close any currently open issues?

closes #3200

Any other comments?

Before

Querying for connected terms from a category was returning both category and tag nodes:

CleanShot 2024-09-03 at 14 54 20@2x

After

Querying for connected terms from a category returns just category nodes:

CleanShot 2024-09-03 at 14 52 49@2x

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 924bbf5 and detected 0 issues on this pull request.

View more on Code Climate.

@josephfusco josephfusco changed the title Added failing test for connectedTerms fix: ensure connectedTerms returns terms for the specified taxonomy only Sep 3, 2024
@josephfusco josephfusco self-assigned this Sep 3, 2024
@coveralls
Copy link

Coverage Status

coverage: 84.176% (+0.002%) from 84.174%
when pulling 924bbf5 on fix/3200-connectedTerms-resolver
into eae8607 on develop.

@jasonbahl jasonbahl merged commit d3542ef into develop Sep 4, 2024
@jasonbahl jasonbahl mentioned this pull request Sep 19, 2024
@justlevine justlevine deleted the fix/3200-connectedTerms-resolver branch December 28, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

connectedTerms of taxonomies nodes return all terms for all taxonomies

4 participants