Skip to content

Conversation

@justlevine
Copy link
Collaborator

@justlevine justlevine commented Aug 17, 2024

What does this implement/fix? Explain your changes.

Adds an .md file for using and extending AbstractConnectionResolver.
Additionally cleans up typos in the AbstractConnectionResolver file.

Does this close any currently open issues?

Part of #2749

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

Where has this been tested?

Operating System: n/a

**WordPress Version:**n/a

@justlevine justlevine marked this pull request as draft August 17, 2024 21:10
@justlevine
Copy link
Collaborator Author

justlevine commented Aug 17, 2024

The .md file is good for review as-is. The "Migration note" I'm still working on. Once it's done I'll mark as ready for review and ping some of the other extension developers.

Refreshed the doc, but it's been half a year, no need for migration notes 😅

@coveralls
Copy link

coveralls commented Aug 17, 2024

Coverage Status

coverage: 83.189% (-0.005%) from 83.194%
when pulling 198f1b4 on justlevine:docs/connection-resolver
into eb824fd on wp-graphql:develop.

@justlevine justlevine force-pushed the docs/connection-resolver branch from c256c03 to 6108dc8 Compare February 8, 2025 17:14
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 198f1b4 and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine marked this pull request as ready for review February 8, 2025 17:17
@justlevine justlevine requested review from jasonbahl and removed request for jasonbahl and josephfusco February 8, 2025 17:17
@justlevine justlevine added status: in review Awaiting review before merging or closing needs: reviewer response This needs the attention of a codeowner or maintainer labels Feb 8, 2025
@jasonbahl jasonbahl merged commit bc3d769 into wp-graphql:develop Feb 13, 2025
36 of 37 checks passed
@justlevine justlevine deleted the docs/connection-resolver branch February 13, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: reviewer response This needs the attention of a codeowner or maintainer status: in review Awaiting review before merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants