fix: missing .svg causing admin_menu not to be registered #3167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clarify in README.md files the intent of the /img directory and /src/assets directory - update the path to the .svg
|
Code Climate has analyzed commit 64b22c7 and detected 0 issues on this pull request. View more on Code Climate. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR fixes an issue with the .svg file used in the admin menu not being able to load because the
./imgdirectory is not included in the bundled plugin. It is excluded via .distignore, so the menu was working for folks working locally from the .git repository but not for folks that have installed the plugin in its final bundled form (most users).Does this close any currently open issues?
closes #3164