fix: set_query_arg should not attempt to merge args #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and merge args instead of override via set_query_arg
…uery_arg will merge
|
Code Climate has analyzed commit 47c2d0b and detected 0 issues on this pull request. View more on Code Climate. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This reverts a change introduced in #3066 that could be a breaking change, and instead handles it by merging args in the connection resolver and using set_query_arg with the merged args (instead of assuming set_query_arg will do the merging under the hood).
Does this close any currently open issues?
n/a
related: #3066
related: #3161
Any other comments?
More info here: #3161 (comment)