Skip to content

Conversation

@justlevine
Copy link
Collaborator

@justlevine justlevine commented Jun 8, 2024

What does this implement/fix? Explain your changes.

This PR:

  1. Updates our composer dev-deps to their latest nonbreaking versions.
  2. Fixes the WPGraphQL::get_static_schema() method to:
    • only call file_get_contents() once
    • correctly return string|null instead of string|false|null

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

Before/after with PHPStan 1.11.x

image

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)

WordPress Version: 6.5.3

@justlevine justlevine requested a review from jasonbahl June 8, 2024 19:10
@justlevine justlevine added status: in review Awaiting review before merging or closing needs: reviewer response This needs the attention of a codeowner or maintainer scope: code quality Refactoring, linting, and enforcing coding standards labels Jun 8, 2024
@coveralls
Copy link

Coverage Status

coverage: 84.285% (-0.005%) from 84.29%
when pulling b432083 on justlevine:chore/update-deps
into 8d06960 on wp-graphql:develop.

jasonbahl
jasonbahl previously approved these changes Jun 27, 2024
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 2510e97 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

coverage: 84.231% (-0.006%) from 84.237%
when pulling 2510e97 on justlevine:chore/update-deps
into d3e06da on wp-graphql:develop.

@jasonbahl jasonbahl merged commit 3557a3e into wp-graphql:develop Jun 28, 2024
@justlevine justlevine deleted the chore/update-deps branch June 28, 2024 16:02
@jasonbahl jasonbahl mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: reviewer response This needs the attention of a codeowner or maintainer scope: code quality Refactoring, linting, and enforcing coding standards status: in review Awaiting review before merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants