fix: $settings_fields param on "graphql_get_setting_section_field_value" filter not passing the correct type
#3139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_field_value" filter is an array before passing it to the filter
|
Code Climate has analyzed commit 9a80f69 and detected 0 issues on this pull request. View more on Code Climate. |
jasonbahl
changed the title
$settings_fields param on "graphql_get_setting_section_field_value" filter not passing the correct type
josephfusco
approved these changes
May 23, 2024
Member
josephfusco
left a comment
josephfusco
left a comment
There was a problem hiding this comment.
Looks good! Possibly add tests to cover this scenario from popping up again
Merged
justlevine
deleted the
fix/3138-graphql_get_setting_section_field_value-param-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This ensures that the
$settings_fieldsparam passed to thegraphql_get_setting_section_field_valuefilter is an array as documented in the filter params. Previously the value was documented to be an array, but was not always returning an array.Does this close any currently open issues?
closes #3138