Skip to content

Conversation

@josephfusco
Copy link
Member

What does this implement/fix? Explain your changes.

Updates the .distignore to prevent unnecessary files from being included in the build.

Does this close any currently open issues?

Fixes #3126

@josephfusco josephfusco requested a review from jasonbahl May 16, 2024 15:45
@justlevine
Copy link
Collaborator

Do we also need to update .gitattributes? Do we even use .gitattributes?

@josephfusco
Copy link
Member Author

@justlevine good call!

Given that .gitattributes is only being used for export-ignore, it seems the only benefit would be for when a zip is downloaded from GitHub.

download zip

If vendor dependencies aren't available in this zip, it doesn't feel like it's adding any value right now.

… distributed on WordPress.org.

Users downloading a .zip of the plugin from Github should get everything downloaded as it is considered a development artifact and not a production artifact.
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 398a3aa and detected 0 issues on this pull request.

View more on Code Climate.

@jasonbahl jasonbahl merged commit 5d3cd82 into develop May 20, 2024
@renatonascalves renatonascalves deleted the fix/3126-clean-up-dist branch May 20, 2024 15:29
@jasonbahl jasonbahl mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove development-related files from SVN on release

4 participants