refactor: split AbstractConnectionResolver::get_args() and ::get_query_args() into ::prepare_*() methods
#3124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_valid_model()`
…s()` into `prepare_*()`
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
justlevine
changed the title
AbstractConnectionResolver::get_args() to ::prepare_args()AbstractConnectionResolver::get_args() to ::prepare_args()
…epare_query_args()`
justlevine
changed the title
AbstractConnectionResolver::get_args() to ::prepare_args()AbstractConnectionResolver::get_args() and ::get_query_args() into ::prepare() methods
justlevine
changed the title
AbstractConnectionResolver::get_args() and ::get_query_args() into ::prepare() methodsAbstractConnectionResolver::get_args() and ::get_query_args() into ::prepare_*() methods
|
Code Climate has analyzed commit b4aad63 and detected 12 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
justlevine
added
type: enhancement
Collaborator
Author
|
Codeclimate issues are preexisting, just getting reflagged because the method names changed. |
This was referenced May 4, 2024
justlevine
dismissed
jasonbahl’s stale review
The merge-base changed after approval.
jasonbahl
previously approved these changes
May 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR makes the following changes to
AbstractConnectionResolver:::get_args()and::get_query_args()now instantiateAbstractConnectionResolver::$argsand::$query_argsonly once.AbstractConnectionResolver::prepare_args()and::prepare_query_args().get_args()andget_query_args()have been replaced in the child resolvers with their::prepare_()counterpart.This improves the DX by reducing the amount of boilerplate needed when extending the AbstractConnectionResolver class, and improving lifecycle consistency, with potential performance benefits for child classes with complex args preparation logic.
There are no breaking changes in this PR.
Important
This PR requires #3123 which should be merged first.
The relevant diff for this PR can be seen at 77d99b9
Does this close any currently open issues?
Part of #2749
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
AbstractConnectionResolver::$argsand::$query_argsare still manually instantiated and theirgraphql_connection_*filters applied inside the class constructor to maintain b/c compatibility with classes that are currently overloading::get_args()or::get_query_args()directly.Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.1.15)
WordPress Version: 6.5.2