refactor: wrap AbstractConnectionResolver::is_valid_model() in ::get_is_valid_model()#3120
Merged
jasonbahl merged 2 commits intowp-graphql:developfrom May 8, 2024
Merged
Conversation
|
Code Climate has analyzed commit 1d084e8 and detected 0 issues on this pull request. View more on Code Climate. |
justlevine
added
type: enhancement
This was referenced May 4, 2024
jasonbahl
approved these changes
May 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR adds the new
AbstractConnectionResolver::get_is_valid_model()method, which wraps the::is_valid_model()logic in the newgraphql_connection_is_valid_modelfilter.This filter is useful for developers who wish to override a Connection Resolver's
is_valid_model()check. The separation of concerns helps those extending a Connection Resolver by minimizing the about of boilerplate they need to copy when overloadingis_valid_model()in their child classes.This is a non-breaking change.
Additionally, the spacing in some docblocks was cleaned up.
Does this close any currently open issues?
There are no breaking changes in this PR.
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
Part of #2749
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.5.2