chore: post #3116 cleanup #3119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@jasonbahl base branch is |
justlevine
force-pushed
the
chore/cleanup-interface-changes
branch
from
f933ca0 to
6cd877c
Compare
|
Code Climate has analyzed commit 6cd877c and detected 0 issues on this pull request. View more on Code Climate. |
Collaborator
Author
|
@jasonbahl my gut tells me theres some more cases we're missing in https://github.com/justlevine/wp-graphql/blob/6cd877cbb75f8175f5cafe37fa6bbc56f333740c/tests/wpunit/InterfaceTest.php#L547 but I'm to tired to figure out what and don't want to hold up the release. Consider this ready for review/merge. |
jasonbahl
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR does some code quality work on #3116 to improve readability / reduce complexity, and backfill some asserts.
Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
I don't think these warrant special changelog comments vs what's already there.
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.5.2