fix: node ids not showing in query analyzer when using DataLoader->load_many()#3114
Merged
jasonbahl merged 2 commits intowp-graphql:developfrom May 2, 2024
Conversation
|
Code Climate has analyzed commit 294f8b7 and detected 0 issues on this pull request. View more on Code Climate. |
Closed
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where Node IDs are not being output by the QueryAnalyzer when a resolver uses the
load_many()method of the DataLoader.This bug can lead to issues with tag-based caching / tag-based cache invalidation as some nodes might not be getting tagged as expected.
Does this close any currently open issues?
closes #3101
Any other comments?
Given the scenario outlined in #3113:
Before
The Node IDs are not present in the Query Analyzer output
After
The Node IDs are present in the Query Analyzer output