Skip to content

Conversation

@justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR restores checks for superfluous whitespace in our phpcs.xml.dist, and runs composer fix-cs to autofix the newly discovered smells.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

Warning

Mass-changing of whitespace is likely to cause merge conflicts with other PRs.

To prevent conflicts, other PRs ready for review should be merged first, develop rebased into this branch, and then composer fix-cs rerun to handle any newly-introduced smells.

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + 8.1.15)

WordPress Version: 6.5

@justlevine justlevine requested a review from jasonbahl April 7, 2024 12:17
@justlevine justlevine added status: in review Awaiting review before merging or closing needs: reviewer response This needs the attention of a codeowner or maintainer status: blocked Progress halted due to dependencies or issues type: chore Maintenance tasks, refactoring, and other non-functional changes scope: code quality Refactoring, linting, and enforcing coding standards labels Apr 7, 2024
@justlevine justlevine force-pushed the chore/superfluous-whitespace branch from a0bf03f to 6e81ffd Compare April 7, 2024 12:25
@coveralls
Copy link

coveralls commented Apr 7, 2024

Coverage Status

coverage: 84.289%. remained the same
when pulling 4032c4c on justlevine:chore/superfluous-whitespace
into 2d5c97e on wp-graphql:develop.

…perfluous-whitespace

# Conflicts:
#	src/Data/Connection/AbstractConnectionResolver.php
jasonbahl
jasonbahl previously approved these changes Apr 23, 2024
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 4032c4c and detected 0 issues on this pull request.

View more on Code Climate.

@jasonbahl jasonbahl merged commit a6173b6 into wp-graphql:develop Apr 23, 2024
@jasonbahl jasonbahl mentioned this pull request Apr 23, 2024
@justlevine justlevine deleted the chore/superfluous-whitespace branch August 3, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: reviewer response This needs the attention of a codeowner or maintainer scope: code quality Refactoring, linting, and enforcing coding standards status: blocked Progress halted due to dependencies or issues status: in review Awaiting review before merging or closing type: chore Maintenance tasks, refactoring, and other non-functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants