coverage: 84.373%. remained the same
when pulling f57709f on ci/update-workflow-actions
into 4dae631 on develop.

WP 5.2 on PHP 7.3 is failing for NodeByUriTest:testDefaultTaxTermByUri, but I am unsure why get_term_by() doesn't return the valid default term 🤔

@jasonbahl @josephfusco any ideas (branch edits open, so feel free to fix directly on this branch if you have a solve)

@justlevine I'm not sure we need to prioritize testing 5.2.

We haven't been testing against it before and according to the telemetry data we collect, we have 0 users on 5.2.

We have:

• 25 users on WordPress 4.9
• 0 users on WordPress 5.0
• 0 users on WordPress 5.1
• 0 users on WordPress 5.2
• 38 users on WordPress 5.3
• 47 user on WordPress 5.4
• 55 users on WordPress 5.5
• 52 users on WordPress 5.6
• 131 users on WordPress 5.7
• 408 users on WordPress 5.8
• 3050 users on WordPress 5.9
• And then more than that on each of the following: 6.0, 6.1, 6.2, 6.3, 6.4, 6.5

@justlevine I'm not sure we need to prioritize testing 5.2.

We haven't been testing against it before and according to the telemetry data we collect, we have 0 users on 5.2.

It's less about 5.2 specifically, and more about testing our "minimum supported version" now and in the future.
5.2 is just the lowest version whose docker still builds. It gives us a nice spread as we work to 2.0, and lets us drop middle versions in the future without worrying too much about coverage.

If it's not worth fixing the Codeception test, I can keep bumping until we find a minimum version that just works.

@justlevine ya, I think the effort is better spent ensuring things work on more recent versions and coming up with a plan / policy for supported versions that we can put into place and follow over time.

i.e. "we will officially support the latest xx versions of WordPress and the last xx versions of PHP" or something to that tune.

Definitely needs more thought than that, but I think there's more value in encouraging folks to update vs putting effort into testing versions we wouldn't actively recommend be used in the first place 🤷🏻‍♂️

Definitely needs more thought than that, but I think there's more value in encouraging folks to update vs putting effort into testing versions we wouldn't actively recommend be used in the first place 🤷🏻‍♂️

💯

The goal of the matrix changes in this PR is not philosophical, only a cleaner restructure of the matrix to make it easier to add/change versions without losing coverage.

Will find a docker build that works as-is and ping you for re-review.

Code Climate has analyzed commit f57709f and detected 0 issues on this pull request.

View more on Code Climate.

@jasonbahl WP 5.5 is the magic number.
Ready for your review.