feat: introduce actions and filters for GraphQL Admin Notices #3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce `graphql_admin_notices_render_notice` action - introduce `graphql_admin_notices_is_plugin_scoped_page` filter
justlevine
reviewed
Apr 3, 2024
jasonbahl
commented
Apr 3, 2024
jasonbahl
commented
Apr 3, 2024
|
Code Climate has analyzed commit 057cad3 and detected 0 issues on this pull request. View more on Code Climate. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR introduces the following:
graphql_admin_notices_render_noticesactiongraphql_admin_notices_render_noticeactiongraphql_admin_notices_is_plugin_scoped_pagefilterThese actions and filters enable 3rd party codebases to hook into the rendering of admin notices registered via
register_graphql_admin_noticeand modify things like:Does this close any currently open issues?
closes #3090
Any other comments?
While working on the new WPGraphQL IDE (https://github.com/wp-graphql/wpgraphql-ide) I wanted to add support for the admin notices registered via
register_graphql_admin_notice()but because of the lack of actions/filters I was not able to add proper support without modifying core WPGraphQL.By introducing these actions/filters I can now add support for GraphQL Admin Notices to additional pages, such as the new IDE.
ex: