refactor: improve loader handling in AbstractConnectionResolver
#3088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR refactors the way
AbstractConnectionResolverhandlesDataLoaders. More specifically:::loader_name()::get_loader_name()is no longer anabstractmethod, and instead calls::loader_name()if it has not already been set as a class property.graphql_connection_loader_namefilter to more easily apply custom data loaders to an existing Connection Resolver (e.g. CPT-specific).AbstractConnectionResolver::$loaderproperty now only gets instantiated once, no matter how many times::get_loader()is called. As a result, all direct calls to::$loaderhave been replaced with::get_loader().::get_loader_name()methods in the child classes have been replaced with::loader_name().There are no breaking changes in this PR.
Does this close any currently open issues?
Part of #2749
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
camelCasemethods inAbstractConnectionResolverforsnake_caseequivalents #3083 , which should be merged first.Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + 8.1.15)
WordPress Version: 6.4.3