refactor: add AbstractConnectionResolver::get_unfiltered_args() public getter
#3086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
added
type: enhancement
justlevine
changed the title
AbstractConnectionResolver::get_unfiltered_args() public getterAbstractConnectionResolver::get_unfiltered_args() public getter
jasonbahl
approved these changes
Apr 22, 2024
This was referenced Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR adds the public
get_unfiltered_args()method toAbstractConnectionResolverfor fetching the GraphQL$argsbefore they have been modified by any filters/side effects.Additionally child classes that were using an unmodified local copy of
$argshave been updated to use::get_unfiltered_args()instead.Does this close any currently open issues?
Part of #2749
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
AbstractConnectionResolver::$unfiltered_argsproperty/getter, we are still setting$this->argsin the constructor multiple times (for backwards compatibility). This will be addressed in a future PR.$unfiltered_argsparameter on several filters, and those will be deprecated in a future PR as well.Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.4.3