refactor: deprecate camelCase methods in AbstractConnectionResolver for snake_case equivalents
#3083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
changed the title
AbstractConnectionResolvercamelCase methods in AbstractConnectionResolver for snake_case equivalents
justlevine
added
type: enhancement
…ling refactor: improve `loader` handling in `AbstractConnectionResolver`
jasonbahl
approved these changes
Apr 22, 2024
…backport/deprecate-camelcased # Conflicts: # src/Data/Connection/AbstractConnectionResolver.php
This was referenced Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR deprecates the following camelCased methods in
AbstractConnectionResolverfor theirsnake_casedequivalents. More specifically:::getSource()=>::get_source()::getContext()=>::get_context()::getLoader()=>::get_loader()::getInfo()=>::get_info()::getShouldExecute()=>::get_should_execute()Does this close any currently open issues?
Part of #2749
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
@todowith the version number before release.Important
As these deprecation warnings will prompt developers to update code, we should wait to merge until other changes warrant their need to edit things (e.g.
prepare_*methods), such as #3088.After #3082 is merged to
develop, it might make sense to create a ConnectionResolver-specific branch, so we can group this PR with others that recommend developers update their code, so they don't need to update their child classes in multiple successive releases.Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.4.3