chore: prepare ConnectionResolver classes for v2 backport#3082
Merged
chore: prepare ConnectionResolver classes for v2 backport#3082
Conversation
This was referenced Mar 30, 2024
justlevine
added
status: in review
This was referenced Mar 30, 2024
…ugin-connection-resolver perf: refactor `PluginConnectionResolver` to only fetch plugins once
…-resolvers-cleanup
|
Code Climate has analyzed commit 6da42cf and detected 0 issues on this pull request. View more on Code Climate. |
Collaborator
Author
|
Fixed the merge conflict |
jasonbahl
approved these changes
Apr 22, 2024
This was referenced Apr 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR makes several cosmetic changes to
Data\Connection\AbstractConnectionResolverand child classes, for the sole purpose making it easier to review backported changes from #2749.More specifically:
Cleaned up doc-blocks and comments.
Reordered the method/property definitions based on the impending changes in refactor!: [WIP] Exploring a ConnectionResolver 2.0 #2749.
Moved initialization of properties that are identical to the class constructor parameters to the top of
__construct().Note: This is the only code change included, and there is no change to the actual code logic (i.e. no side effects from changing the order of operations).
Also includes perf: refactor
PluginConnectionResolverto only fetch plugins once #3084Does this close any currently open issues?
Not yet ;-)
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
Future PRs in this series might only make sense to merge as a group, so extenders don't need to upgrade the connection resolvers multiple times.
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.1.15)
WordPress Version: 6.4.3