fix: GraphiQL IDE test failures#3079
Merged
jasonbahl merged 32 commits intowp-graphql:developfrom Mar 27, 2024
Merged
Conversation
…es form WPGraphQL IDE repo
…devDependencies from the WPGraphQL IDE repo
- remove wp-env from package.json and put it in its own .wp-env.json file - remove unused remark scripts - remove .remarkrc
… @wordpress/scripts)
- add jest dependencies
…de as an external plugin)
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 8ee91e4 and detected 0 issues on this pull request. View more on Code Climate. |
josephfusco
approved these changes
Mar 27, 2024
Member
josephfusco
left a comment
josephfusco
left a comment
There was a problem hiding this comment.
Great work with fixing the failing graphiql tests and adding playwright! 🔥
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR converts the GraphiQL IDE e2e tests to use Playwright instead of puppeteer and updates dependencies so that the tests can be successfully run again.
Does this close any currently open issues?
closes #2985
Any other comments?
While we are focused on re-building the IDE over at https://github.com/wp-graphql/wpgraphql-ide, we need the tests to run
on the "legacy IDE" so that we can ensure merging things like dependabot PRs don't break things in the meantime.
This migrates the e2e tests and removes the unit tests. Unit tests will be added back to the new WPGraphQL IDE repo.