fix: admin_enqueue_scripts callback should expect a possible null value passed to it#3057
Merged
jasonbahl merged 2 commits intowp-graphql:developfrom Feb 23, 2024
Conversation
…argument don't throw errors. It's supposed to pass a string, but it's been reported to not always pass a string.
josephfusco
approved these changes
Feb 22, 2024
josephfusco
previously approved these changes
Feb 22, 2024
Member
josephfusco
left a comment
josephfusco
left a comment
There was a problem hiding this comment.
Once the linting issues are resolved this one is good!
|
Code Climate has analyzed commit 7093cc8 and detected 0 issues on this pull request. View more on Code Climate. |
Collaborator
Author
|
fyi, tests are failing due to #3060 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This updates the enqueue_admin_assets callback to expect a possible null value for the argument passed from
do_action( 'admin_enqueue_scripts' );Does this close any currently open issues?
closes #3056