fix: isPostsPage on content type #3048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…returns a `ContentType` that `isPostsPage` field returns true
…ble Interface as any node with a URI should be able to identify whether it is or is not the posts page or front page. Defaults to false, but individual implementing types (ContentType, Page) can override the resolver as applicable. - update the PostType Model to return true if show_on_front is set to "page" and update Post model to return `false` for `isPostsPage` as a Post Object won't ever resolve as the posts page based on the current NodeResolver strategy (see: https://github.com/wp-graphql/wp-graphql/blob/develop/src/Data/NodeResolver.php#L226)
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| return false; | ||
| // the "post" ContentType is always represented as isPostsPage | ||
| return 'post' === $this->name; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
3 tasks
jasonbahl
changed the title
|
Code Climate has analyzed commit 7ca1dcd and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jasonbahl
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This updates the ContentType.isPostsPage resolver to return true for the "Post" ContentType.
Does this close any currently open issues?
closes #2514
Any other comments?
BEFORE
isPostsPage and isFrontPage have to be separately queried for on Page and ContentType types, and
isPostsPagereturns false for the ContentType that is representing the Posts Page.AFTER
I can now query isFrontPage and isPostsPage as a field of the
UniformResourceIdentifiableType.And now we see that
isPostsPageappropriately returnstruewhen aContentTypeis returned as the posts page.