coverage: 84.756%. remained the same
when pulling a3696ff on jasonbahl:fix/2981-php-deprecation-error
into 49e2d5a on wp-graphql:develop.

👋🏻 Hey Jason...

This can be squelched by adding the following to the list of properties in AppContext.php. Tested locally with PHP 8.3 and no more deprecation warnings 😄

/**
 * Stores the class to use for the connection query.
 *
 * @var WP_Query|null
 */
public $connection_query_class = null;

👋🏻 Hey Jason...

This can be squelched by adding the following to the list of properties in AppContext.php. Tested locally with PHP 8.3 and no more deprecation warnings 😄

/**
 * Stores the class to use for the connection query.
 *
 * @var WP_Query|null
 */
public $connection_query_class = null;

This might be a "why not both?" situation, since while $connection_query_class is the problem in the core plugin, the current pattern encourages general overloading the AbstractConnectionResolver class with custom properties, so many plugins are triggering similar errors on for other undeclared variables. 🤔
The type will probably need to be broader than ?\WP_Query (while still hopefully avoiding a mixed).

Similarly (more of a note to self), while squelching the deprecation warning is our immediate concern, we do need to think about what the ideal DX should be for overloading the ConnectionResolver in order to reuse an existing one instead of needing to define an entire child class (or even if overloading is the way to do it vs lets say a callable in the $config[] ).

related: #2821

I think this is fixed, now. Thanks!

This might be a "why not both?" situation

@justlevine @gregrickaby ya, I agree with this (and everything @justlevine said after).

We definitely need to shore up some patterns for hooking into AppContext. For now, I think we can do both, and then circle back in the future on what ideal patterns should be if/when AppContext needs to be modified during resolution, etc

Code Climate has analyzed commit a3696ff and detected 0 issues on this pull request.

View more on Code Climate.