chore: update composer dev-dependencies and use php-compatibility:develop branch to 8.0+ lints
#3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
added
status: in review
|
Code Climate has analyzed commit 3dd019f and detected 0 issues on this pull request. View more on Code Climate. |
Collaborator
|
@justlevine I merged #3007 and updated this PR to have the latest merged code. Tests pass now. Thanks for your work on this! 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR updates our Composer dev-dependencies to their latest versions. Additionally, it explicitly sets
phpcompatibility/php-compatibilityto thedev-developbranch, so PHPCS can catch issues related to PHP 8.0+Reference
Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
This change will expose the bug addressed in #3007 , so the linting will pass one that is merged.
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.4.2