Skip to content

Conversation

@justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR replaces the deprecated call to AbstractConnectionResolver::setQueryArg() in ContentType.connectedTaxonomies resolver with AbstractConnectionResolver::set_query_arg().

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.1.15)

WordPress Version: 6.4.2

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit a3510a4 and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine requested a review from jasonbahl December 30, 2023 23:56
@justlevine justlevine added type: bug Issue that causes incorrect or unexpected behavior status: in review Awaiting review before merging or closing scope: code quality Refactoring, linting, and enforcing coding standards labels Dec 30, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.792%. remained the same
when pulling a3510a4 on justlevine:fix/replace-deprecated-setQueryArg
into 683352d on wp-graphql:develop.

@justlevine justlevine changed the title fix: replace deprecated setQueryArg() with set_query_arg() fix: replace deprecated AbstractConnectionResolver::setQueryArg() call with ::set_query_arg() Jan 10, 2024
@justlevine
Copy link
Collaborator Author

@jasonbahl can you review this when you get a minute?

@jasonbahl jasonbahl merged commit fa56cf1 into wp-graphql:develop Jan 23, 2024
@justlevine justlevine deleted the fix/replace-deprecated-setQueryArg branch January 23, 2024 02:21
This was referenced Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code quality Refactoring, linting, and enforcing coding standards status: in review Awaiting review before merging or closing type: bug Issue that causes incorrect or unexpected behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants