fix: Only use Appsero add_plugin_data if the Appsero Client is v1.2.1 or higher #2599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jasonbahl
commented
Nov 2, 2022
justlevine
reviewed
Nov 2, 2022
wp-graphql.php
Outdated
| // @phpstan-ignore-next-line | ||
| $client->insights()->add_plugin_data()->init(); | ||
| // If the Appsero client is version 1.2.0 or higher, add plugin data | ||
| if (version_compare( $client->version, '1.2.1', '>=' ) ) { |
Collaborator
There was a problem hiding this comment.
Would it be more future proof if we did a class/method_exists() instead of version_compare(), JIC they remove/rename the method in a later release - and even if it is more futureproof, do we care?
justlevine
reviewed
Nov 2, 2022
justlevine
previously approved these changes
Nov 2, 2022
Collaborator
There was a problem hiding this comment.
Looks good (sans the spacing issue CI picked up), and testing manually with WP Maximum Upload File Size, it works as expected.
Left some CodeQuality suggestions that are probably just my penchant for premature optimization and can be ignored.
…raphql#2597-appsero-add_plugin_data-bug # Conflicts: # wp-graphql.php
|
Code Climate has analyzed commit bc71c1b and detected 0 issues on this pull request. View more on Code Climate. |
Merged
This was referenced Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Does this close any currently open issues?
closes #2597