feat: add X-GraphQL-URL to headers of GraphQL Responses #2565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lows for caching clients to identify the endpoint caches should be related to. see: varnish/varnish-modules#41 (comment) - Since the WPGraphQL endpoint can be queried at multiple domains, the caching client can't reliably use the http.host for this. As queries can be queried from host1 and data can be written from host2. ie publicapi.domain.com and content.wphost.com.
justlevine
reviewed
Oct 6, 2022
- use `Router::$route` instead of `get_graphql_setting()` to determine the endpoint and ensure consistency with existing filters - Change header name to X-GraphQL-URL instead of endpoint - update tests
- instantiate Router::$route with graphql_get_endpoint() - use get_graphql_endpoint() to determine if rewrite rules should be flushed - update settings to use get_graphql_endpoint instead of Router::$route - update tests
jasonbahl
changed the title
… a non falsy value to match previous behavior
|
Code Climate has analyzed commit 6201bb0 and detected 0 issues on this pull request. View more on Code Climate. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This exposes a new
X-GraphQL-Endpointheader to be returned in HTTP requests for WPGraphQL.Does this close any currently open issues?
closes #2564
Any relevant logs, error output, GraphiQL screenshots, etc?