remove query param in favor of hash

josephfusco · josephfusco · commit c597d7df8ec2 · 2024-05-30T12:34:40.000-04:00
diff --git a/src/Admin/Settings/SettingsRegistry.php b/src/Admin/Settings/SettingsRegistry.php
@@ -678,7 +678,7 @@ public function show_forms() {
 	/**
 	 * Tabbable JavaScript codes & Initiate Color Picker
 	 *
-	 * This code uses query arguments and localstorage for displaying active tabs
+	 * This code uses URL hash fragments and localStorage for displaying active tabs
 	 *
 	 * @return void
 	 */
@@ -692,11 +692,10 @@ public function script() {
 				// Switches option sections
 				$('.group').hide();
 				var activetab = '';
-				var urlParams = new URLSearchParams(window.location.search);
-				var queryTab = urlParams.get('tab');
+				var urlHash = window.location.hash;
 
-				if (queryTab) {
-					activetab = '#' + queryTab;
+				if (urlHash) {
+					activetab = urlHash;
 					if (typeof (localStorage) != 'undefined') {
 						localStorage.setItem("activetab", activetab);
 					}
@@ -734,8 +733,7 @@ function () {
 					if (typeof (localStorage) != 'undefined') {
 						localStorage.setItem("activetab", clicked_group);
 					}
-					urlParams.set('tab', clicked_group.substring(1));
-					history.replaceState(null, '', '?' + urlParams.toString());
+					history.replaceState(null, '', clicked_group);
 					$('.group').hide();
 					$(clicked_group).fadeIn();
 					evt.preventDefault();
