Skip to content

Allow collecting PHPUnit coverage #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrsdizzie merged 7 commits into from
Feb 26, 2025
Merged

Allow collecting PHPUnit coverage #6041

mrsdizzie merged 7 commits into from
Feb 26, 2025

Conversation

@swissspidy
Copy link
Member

@swissspidy swissspidy commented Jan 30, 2025 •
edited
Loading

Fixes a currently failing code coverage job because the PHPUnit config is outdated.

See #6035

The PHP 5.6 failures are known, see #6018

@swissspidy swissspidy added the scope:testing Related to testing label Jan 30, 2025
@swissspidy swissspidy added this to the 2.12.0 milestone Jan 30, 2025
@swissspidy swissspidy requested a review from a team as a code owner January 30, 2025 22:01
@swissspidy swissspidy mentioned this pull request Jan 30, 2025
Merged
@swissspidy
Copy link
Member Author

swissspidy commented Feb 25, 2025

@wp-cli/committers friendly ping

@mrsdizzie
Copy link
Member

mrsdizzie commented Feb 25, 2025

Is this related warning intentional?

 Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 21:
  - Element 'coverage': This element is not expected.

  Test results may not be as expected.

I see we merged similar PRs already, just curious

@swissspidy
Copy link
Member Author

swissspidy commented Feb 26, 2025

Yes, that's expected because those tests use an older PHPUnit version due to the older PHP version.

@mrsdizzie mrsdizzie merged commit 63115a0 into main Feb 26, 2025
44 of 47 checks passed
@mrsdizzie mrsdizzie deleted the phpunit-coverage-config branch February 26, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees

No one assigned

Labels

scope:testing Related to testing

Projects

None yet

Milestone

2.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@swissspidy @mrsdizzie