Skip to content

Add support for formatting boolean values in WP_CLI\Formatter #5928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 5 commits into from
Apr 26, 2024
Merged

Add support for formatting boolean values in WP_CLI\Formatter #5928

swissspidy merged 5 commits into from
Apr 26, 2024

Conversation

@tfirdaus
Copy link
Contributor

@tfirdaus tfirdaus commented Apr 11, 2024

This Pull Request aims to fix issue #5542, where a false value is currently transformed into an empty string.

+----+--------+
| id | status |
+----+--------+
| 1  | 1      |
| 2  |        |
+----+--------+

With these updates, the output for boolean values will be transformed into true and false accordingly.

+----+--------+
| id | status |
+----+--------+
| 1  | true   |
| 2  | false  |
+----+--------+

@tfirdaus tfirdaus requested a review from a team as a code owner April 11, 2024 16:25
swissspidy
swissspidy reviewed Apr 11, 2024
View reviewed changes
swissspidy
swissspidy reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

BrianHenryIE
BrianHenryIE reviewed Apr 11, 2024
View reviewed changes
@swissspidy swissspidy added this to the 2.11.0 milestone Apr 26, 2024
@swissspidy
Copy link
Member

swissspidy commented Apr 26, 2024

It's hack day, so let's 🚢 it!

#5935

@swissspidy swissspidy merged commit 46051ea into wp-cli:main Apr 26, 2024
@swissspidy swissspidy mentioned this pull request Apr 26, 2024
Merged
@danielbachhuber danielbachhuber mentioned this pull request Apr 26, 2024
Merged
@danielbachhuber danielbachhuber removed this from the 2.11.0 milestone Apr 26, 2024
@danielbachhuber
Copy link
Member

danielbachhuber commented Apr 26, 2024

Thanks for the PR, @tfirdaus !

We decided to revert this for now in #5940 because:

  1. It's technically a breaking change.
  2. I'm concerned it will unexpectedly break folks' scripts that are parsing tabular output.

I filed #5542 against the 3.0 milestone. We can re-open this PR when 3.0 is the next slated release.

@tfirdaus
Copy link
Contributor Author

tfirdaus commented Apr 26, 2024

@danielbachhuber No worries. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrianHenryIE BrianHenryIE BrianHenryIE left review comments

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

internal-api:wp-cli-utils-format-items

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tfirdaus @swissspidy @danielbachhuber @BrianHenryIE