Skip to content

Extract cacert from Phar for cURL#5777

Merged
schlessera merged 1 commit intomainfrom
fix/cacert-in-phar
May 3, 2023
Merged

Extract cacert from Phar for cURL#5777
schlessera merged 1 commit intomainfrom
fix/cacert-in-phar

Conversation

@schlessera
Copy link
Copy Markdown
Member

The Requests library already points to its own bundled certificates file in some instances. In case the library is also compiled into a Phar file, cURL will not be able to use the certificate, as it cannot read the file from within the Phar archive. We'll need to extract the file into a temporary location first for this to work properly.

This fixes the following issue observed during deployment runs:
Image 2023-05-02 at 1 44 49 PM

@schlessera schlessera added scope:distribution Related to distribution bug labels May 3, 2023
@schlessera schlessera added this to the 2.8.0 milestone May 3, 2023
@schlessera schlessera requested a review from a team as a code owner May 3, 2023 08:07
@schlessera schlessera merged commit 2efbaad into main May 3, 2023
@schlessera schlessera deleted the fix/cacert-in-phar branch May 3, 2023 08:21
@schlessera
Copy link
Copy Markdown
Member Author

This did not actually fix the mentioned issue.

@danielbachhuber
Copy link
Copy Markdown
Member

danielbachhuber commented May 4, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug scope:distribution Related to distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants