Skip to content

Add border.radiusSizes to theme-i18n.json #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 4 commits into from
Dec 10, 2025
Merged

Add border.radiusSizes to theme-i18n.json #468

swissspidy merged 4 commits into from
Dec 10, 2025

Conversation

@t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Dec 2, 2025

WordPress 6.9 introduces a new border.radiusSizes key in theme.json to define border-radius presets.

I have submitted this PR to make these preset names translatable in the make-pot command.

@t-hamano t-hamano requested a review from a team as a code owner December 2, 2025 08:31
@t-hamano t-hamano changed the title Theme i18n radius sizes Add border.radiusSizes to theme-i18n.json Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy
Copy link
Member

swissspidy commented Dec 2, 2025

Thanks. Please note we have automation in place nowadays to handle this:

i18n-command/.github/workflows/update-schemas.yml

Lines 22 to 77 in 94f72dd

update-schemas: #----------------------------------------------------------
name: Update i18n schema fallback files
runs-on: ubuntu-latest
steps:
- name: Check out source code
uses: actions/checkout@v6
- name: Configure git user
run: |
git config --global user.email "[email protected]"
git config --global user.name "wp-make-coffee"
- name: Check if remote branch exists
run: echo "REMOTE_BRANCH_EXISTS=$([[ -z $(git ls-remote --heads origin update-schemas) ]] && echo "0" || echo "1")" >> $GITHUB_ENV
- name: Create branch to base pull request on
if: env.REMOTE_BRANCH_EXISTS == 0
run: |
git checkout -b update-schemas
- name: Fetch existing branch to add commits to
if: env.REMOTE_BRANCH_EXISTS == 1
run: |
git fetch --all --prune
git checkout update-schemas
git pull --no-rebase
- name: Download latest schema files
run: |
curl -s https://develop.svn.wordpress.org/trunk/src/wp-includes/theme-i18n.json -o assets/theme-i18n.json
curl -s https://develop.svn.wordpress.org/trunk/src/wp-includes/block-i18n.json -o assets/block-i18n.json
- name: Check if there are changes
run: echo "CHANGES_DETECTED=$([[ -z $(git status --porcelain) ]] && echo "0" || echo "1")" >> $GITHUB_ENV
- name: Commit changes
if: env.CHANGES_DETECTED == 1
run: |
git add assets/theme-i18n.json
git add assets/block-i18n.json
git commit -m "Update schema fallback files - $(date +'%Y-%m-%d')"
git push origin update-schemas
- name: Create pull request
if: |
env.CHANGES_DETECTED == 1 &&
env.REMOTE_BRANCH_EXISTS == 0
uses: repo-sync/pull-request@v2
with:
source_branch: update-schemas
destination_branch: ${{ github.event.repository.default_branch }}
github_token: ${{ secrets.GITHUB_TOKEN }}
pr_title: Update schema fallback files
pr_body: "**This is an automated pull-request**\n\nRefreshes the i18n schema files with the latest changes from core.\n\nThese are only used as a fallback if they can't be accessed directly."
pr_reviewer: swissspidy
pr_label: scope:distribution

These file updates aren't usually necessary anyway as they are just fallbacks for when we can't fetch the file from SVN for whatever reason.

@t-hamano
Revert "Add test"
c9b43a2 
This reverts commit 0fceca8.
@swissspidy
Copy link
Member

swissspidy commented Dec 2, 2025

Yeah that test will fail until the change is merged in core.

@t-hamano
Copy link
Contributor Author

t-hamano commented Dec 2, 2025

Should I update the tests in this PR after the changes are committed in core?

@swissspidy
Copy link
Member

swissspidy commented Dec 7, 2025

Sure, why not :) You already wrote them, so can't hurt :)

@swissspidy
Reapply "Add test"
37adeb8 
This reverts commit c9b43a2.
@swissspidy swissspidy added this to the 2.6.7 milestone Dec 10, 2025
@swissspidy swissspidy merged commit 188ae26 into wp-cli:main Dec 10, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

command:i18n-make-pot

Projects

None yet

Milestone

2.6.7

Development

Successfully merging this pull request may close these issues.

2 participants

@t-hamano @swissspidy